feat(gin): add option to use escaped path#4420
Merged
appleboy merged 3 commits intogin-gonic:masterfrom Nov 27, 2025
ldesauw:feat/ldesauw/use_escaped_path
Merged
feat(gin): add option to use escaped path#4420appleboy merged 3 commits intogin-gonic:masterfrom ldesauw:feat/ldesauw/use_escaped_path
appleboy merged 3 commits intogin-gonic:masterfrom
ldesauw:feat/ldesauw/use_escaped_path
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4420 +/- ##
==========================================
- Coverage 99.21% 98.85% -0.37%
==========================================
Files 42 44 +2
Lines 3182 2957 -225
==========================================
- Hits 3157 2923 -234
- Misses 17 21 +4
- Partials 8 13 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
appleboy
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
This pull request introduces an option to used
url.EscapedPath()to determine parameters instead of the usual Path.There was already an option to use
url.RawPathbut this field should not be used as stated here : https://pkg.go.dev/net/url@master#URL and this caused issue when having%252Fin the requested path (see #4033)I added an option to use EscapedPath() instead.
What Changed
Testing
Added TestEngineHandleContextUseEscapedPathPercentEncoded() to check that the path received by the handler is indeed the escapedPath.
Added TestEngineHandleContextUseRawPathPercentEncoded() to display the difference of behavior with the current RawPath
Added TestEngineHandleContextUseEscapedPathOverride() to test that UseEscapedPath override useRawPath.
Related Issues
Closes #4033