refactor(logs): apply user attributes to log regardless of send_default_pii#843
Merged
refactor(logs): apply user attributes to log regardless of send_default_pii#843
send_default_pii#843Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 73.64% 73.66% +0.01%
==========================================
Files 64 64
Lines 7728 7726 -2
==========================================
Hits 5691 5691
+ Misses 2037 2035 -2 🚀 New features to boost your workflow:
|
Swatinem
approved these changes
Jun 16, 2025
send_default_piisend_default_pii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have decided that SDKs should ignore
send_default_piiwhen setting user attributes on logs because that's what we do for other data types such as events.(explanation: any integration that can set the user must honor
send_default_pii, so they won't set the user if that flag is off. Then, the only way to have auseron the scope is for the Sentry user to manually set it, in which case we always want to let them do it and send the data, regardless ofsend_default_pii.)Technically this is a breaking change even though it's pretty unlikely that someone is already using this.
As an alternative we could just ignore the parameter.