refactor(tracing): refactor internal code and improve docs#839
Merged
Conversation
lcian
commented
Jun 12, 2025
| pub(crate) exceptions: Vec<Exception>, | ||
| /// If `true`, stringify and store errors in `self.json_values` under the original field name | ||
| /// else (default), convert to `Exception`s and store in `self.exceptions`. | ||
| store_errors_in_values: bool, |
Member
Author
There was a problem hiding this comment.
As of this PR, store_errors_in_values = true will be used for breadcrumbs.
We will use the same behavior for logs, so instead of duplicating code we make it a flag here on the visitor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 73.36% 73.40% +0.03%
==========================================
Files 64 64
Lines 7678 7682 +4
==========================================
+ Hits 5633 5639 +6
+ Misses 2045 2043 -2 🚀 New features to boost your workflow:
|
Swatinem
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventFilter::exceptionand always attach exception #768errorsfield in the JSON data of the breadcrumb, which doesn't make much sense. Now we'll store them in separate fields, retaining the original nameexample:
Before:

After:
