feat(core): implement Tracing without Performance#811
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 73.05% 72.81% -0.25%
==========================================
Files 63 63
Lines 7267 7308 +41
==========================================
+ Hits 5309 5321 +12
- Misses 1958 1987 +29 🚀 New features to boost your workflow:
|
lcian
commented
May 19, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good overall, I have some (mostly minor) suggestions though
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
lcian
commented
May 22, 2025
lcian
commented
May 22, 2025
szokeasaurusrex
approved these changes
May 27, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good, please address comments before merging (I marked some as nit or optional, you can ignore those if you want)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Tracing without Performance (spec).
This is done by having an additional
PropagationContextattribute on the scope that holds a "fake"trace_idandspan_id.When applying the scope to an event, if there is no ongoing span set on the scope, we create the
tracecontext from thePropagationContext.Additionally, adds an API
scope.iter_trace_propagation_headersthat should be preferred over something like:because it will use the
PropagationContextas a fallback.Closes #796
Also makes a minor adjustment to trace and span ids where we now use the
Displayimpl forDebug, otherwise we were getting u8 arrays when using e.g.dbg!with the derived one which is not very useful.