Merged
Conversation
Swatinem
reviewed
May 8, 2025
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
you can still run these doctests by pulling in the main sentry crate as a dev dependency.
we use this pattern in the doctests for sentry-core itself.
We are abusing dependency cycles in a very creative way here. Not really a fan of it tbh, but it kinda works.
Member
Author
Ah cool, we were actually already pulling |
Swatinem
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doctests show usage from the point of view of the
sentrycrate, as we are importing the subcrate asuse sentry::integrations::opentelemetry as sentry_opentelemetry;.Therefore the first doctest will not compile.
The second will also not compile because we have the imports in the first.
Let's just use
ignoreon both of them.