feat(otel): add OpenTelemetry SpanProcessor, Propagator, Extractor#779
feat(otel): add OpenTelemetry SpanProcessor, Propagator, Extractor#779
Conversation
|
Seems like Windows CI is getting stuck on |
adinauer
left a comment
There was a problem hiding this comment.
Just gave this a quick glance and left some comments on what I noticed so far.
Thank you! |
|
Apparently we need to put each test in a different file or they will get stuck on Windows. |
Swatinem
left a comment
There was a problem hiding this comment.
this looks reasonable to me.
Its a bit unfortunate how the lack of "onlyspans" means that you have to still deal with needing access to a TransactionOrSpan object instead of just being able to push finished spans with opaque parent ids into a global span sink.
|
@lcian what is the end user experience of using this? I see you're adding stuff on the EDIT: nvm that's a docstring, ignore 🤦 |
Yeah this is the snippet to set it up |
Creates a new crate
sentry-opentelemetryfor integration with OTEL.The implementation is based on a SpanProcessor that creates and finishes Sentry spans on OTEL span start/end.
There's also a Propagator/Extractor that injects the metadata (e.g. HTTP headers) required for distributed tracing to work.
It's based on our implementation for JS and other SDKs (https://develop.sentry.dev/sdk/telemetry/traces/opentelemetry/).
The goal with this initial version is:
Feedback appreciated on:
SPAN_MAP, general Rust stuff, additions to performance API (@Swatinem)There are some todo items which will be addressed in follow-up PRs (not necessarily in this release).