refactor(tracing): remove EventFilter::exception and always attach exception#768
Merged
refactor(tracing): remove EventFilter::exception and always attach exception#768
EventFilter::exception and always attach exception#768Conversation
Swatinem
approved these changes
Apr 10, 2025
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
just a heads up that this will be a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when capturing something with e.g.
tracing::warn!(error = std_dyn_err(&e), "Something went wrong");the following would happen based on theEventFilter:EventFilter::Exception->exception_from_event(includeserrorin theexceptionfield of theEvent)EventFilter::Event->event_from_event(ignoreserror)EventFilter::Breadcrumb->breadcrumb_from_event(ignoreserror)So, both
EventandBreadcrumbwould counterintuitively ignore the field.With this change:
EventFilter::Exceptionandexception_from_eventin favor ofEventFilter::Eventandevent_from_event, which will behave as the oldexception_from_event(attachingerror, if any)errorfield as structured data in breacrumbs. It's attached as a list of errors from the outermost to the innermost, mimicking the way it would be reported in a Sentry issue.Closes #702