Make jruby CI work with explicit jar-dependencies install#2550
Merged
sl0thentr0py merged 11 commits intomasterfrom Feb 10, 2025
Merged
Make jruby CI work with explicit jar-dependencies install#2550sl0thentr0py merged 11 commits intomasterfrom
sl0thentr0py merged 11 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2550 +/- ##
==========================================
+ Coverage 69.26% 69.69% +0.43%
==========================================
Files 126 126
Lines 4737 4759 +22
==========================================
+ Hits 3281 3317 +36
+ Misses 1456 1442 -14
|
13269db to
690ee2c
Compare
solnic
commented
Feb 10, 2025
| - name: Bundle Jruby | ||
| if: {{ contains(matrix.ruby_version, "jruby") }} | ||
| run: gem install jar-dependencies | ||
| run: bundle |
Collaborator
Author
There was a problem hiding this comment.
@sl0thentr0py hah that was my "yeah I guess we may have to install it manually in a separate step" last resort thought last Friday 🙃
a6ef7f9 to
9fead98
Compare
fa78c0c to
bd7357c
Compare
bd7357c to
3267232
Compare
sl0thentr0py
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to ruby/psych#700 (comment) it should work now 🤞🏻
#skip-changelog