Skip to content

feat(logs): Make the logging integration send Sentry logs#4143

Merged
antonpirker merged 18 commits intomasterfrom
logger_ourlogs
Mar 27, 2025
Merged

feat(logs): Make the logging integration send Sentry logs#4143
antonpirker merged 18 commits intomasterfrom
logger_ourlogs

Conversation

@colin-sentry
Copy link
Contributor

@colin-sentry colin-sentry commented Mar 17, 2025 •
edited by antonpirker
Loading

We have integrations that make the python logger create breadcrumbs and issues. This adds a third handler which creates Sentry logs on logger.log statements.

Enable the logger with:

sentry_sdk.init(
    ...
    _experiments={
        "enable_sentry_logs": True
    }
)

some_logger = logging.Logger("some-logger")
some_logger.info('Finished sending answer! #chunks=%s', chunks)

Screenshot 2025-03-17 at 4 12 27 PM

Refs #4150

@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (6f49bfb) to head (5910b07).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/logging.py 71.15% 2 Missing and 13 partials ⚠️
sentry_sdk/client.py 76.47% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
- Coverage   79.57%   79.57%   -0.01%     
==========================================
  Files         141      141              
  Lines       15738    15790      +52     
  Branches     2675     2696      +21     
==========================================
+ Hits        12524    12565      +41     
+ Misses       2369     2368       -1     
- Partials      845      857      +12
Files with missing lines Coverage Δ
sentry_sdk/_experimental_logger.py 100.00% <100.00%> (ø)
sentry_sdk/consts.py 92.85% <ø> (ø)
sentry_sdk/client.py 79.00% <76.47%> (-0.17%) ⬇️
sentry_sdk/integrations/logging.py 82.78% <71.15%> (-6.33%) ⬇️

... and 3 files with indirect coverage changes

@antonpirker antonpirker changed the title feat(logs): Make the python logger go to ourlogs feat(logs): Make the logging integration send Sentry logs Mar 18, 2025
antonpirker
antonpirker reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good. I have some questions

@colin-sentry colin-sentry requested a review from a team as a code owner March 24, 2025 15:42
@antonpirker
Copy link
Contributor

antonpirker commented Mar 27, 2025

@colin-sentry I have moved the new parameter sentry_logs_level to the end of the parameter list, so we do not break peoples setup if they use positional parameters.

antonpirker
antonpirker approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. 🔥

@antonpirker antonpirker merged commit 2f4b028 into master Mar 27, 2025
138 of 139 checks passed
@antonpirker antonpirker deleted the logger_ourlogs branch March 27, 2025 08:52
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 27, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antonpirker antonpirker antonpirker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colin-sentry @antonpirker