feat(tracing): Add __repr__ to Baggage#4043
Merged
szokeasaurusrex merged 1 commit intomasterfrom Feb 12, 2025
Merged
Conversation
Member
Author
|
Gonna add a simple test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4043 +/- ##
=======================================
Coverage 80.24% 80.25%
=======================================
Files 139 139
Lines 15415 15417 +2
Branches 2606 2606
=======================================
+ Hits 12370 12373 +3
Misses 2203 2203
+ Partials 842 841 -1
|
0edc902 to
53e7672
Compare
The default `__repr__` does not show what is in the `Baggage`, making it extremely difficult to debug code involving `Baggage` objects. Add a `__repr__` which includes the serialized `Baggage` to improve debuggability.
53e7672 to
9115b96
Compare
sentrivana
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
__repr__does not show what is in theBaggage, making it extremely difficult to debug code involvingBaggageobjects. Add a__repr__which includes the serializedBaggageto improve debuggability.Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.