feat(spans): track and report spans that were dropped#4005
Merged
constantinius merged 14 commits intomasterfrom Feb 4, 2025
Merged
feat(spans): track and report spans that were dropped#4005constantinius merged 14 commits intomasterfrom
constantinius merged 14 commits intomasterfrom
Conversation
<!-- Describe your PR here --> --- Thank you for contributing to `sentry-python`! Please add tests to validate your changes, and lint your code using `tox -e linters`. Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.
Extend tests to check for correct `_meta` content. Cleanup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4005 +/- ##
==========================================
+ Coverage 80.15% 80.23% +0.07%
==========================================
Files 139 139
Lines 15403 15388 -15
Branches 2597 2597
==========================================
- Hits 12347 12346 -1
+ Misses 2211 2198 -13
+ Partials 845 844 -1
|
sentrivana
approved these changes
Feb 3, 2025
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Thanks for simplifying! Overall looks good to me, but please address comments before merging
Contributor
|
Oh yeah, and the |
Additional linter fixes
sentrivana
reviewed
Feb 4, 2025
sentrivana
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_SpanRecordernow keeps track ofdropped_spans, i.e. when abovemax_spans.When spans were dropped, the
"spans"property will be wrapped in anAnnotatedValue, reporting the mutation.