Set level based on status code for HTTP client breadcrumbs#4004
Merged
sentrivana merged 7 commits intomasterfrom Feb 11, 2025
Merged
Set level based on status code for HTTP client breadcrumbs#4004sentrivana merged 7 commits intomasterfrom
sentrivana merged 7 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4004 +/- ##
==========================================
+ Coverage 80.16% 80.22% +0.05%
==========================================
Files 139 139
Lines 15397 15406 +9
Branches 2597 2601 +4
==========================================
+ Hits 12343 12359 +16
+ Misses 2210 2202 -8
- Partials 844 845 +1
|
antonpirker
approved these changes
Feb 10, 2025
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
Just a tiny nit picking question, otherwise looks good!
Comment on lines
+173
to
+178
| if level: | ||
| scope.add_breadcrumb( | ||
| type="http", category="httplib", data=span._data, level=level | ||
| ) | ||
| else: | ||
| scope.add_breadcrumb(type="http", category="httplib", data=span._data) |
Contributor
There was a problem hiding this comment.
Does it mess up the breadcrumb if we would add it with level=None?
Contributor
Author
There was a problem hiding this comment.
I don't think but wasn't entirely sure so opted for the safe version 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe_create_breadcrumbs_from_spanto set thelevelof the breadcrumb towarningfor the client error range (4xx) and toerrorfor server errors (5xx)responsesin multiple places, but they're not actually active (theactivatedecorator is missing) and we're making actual requests outside -- we should clean this upresponsesfor stdlib/requests tests since they patch something that we patchhttpx,stdlib,requests,aiohttptests for the new behaviorrequeststests to 3.7+ since in 3.6, the span is finished before the HTTP status is set for some reason...Closes #4000