Skip to content

[2] Add more min versions of frameworks#3973

Merged
sentrivana merged 13 commits intomasterfrom
ivana/tox-script-4
Feb 11, 2025
Merged

[2] Add more min versions of frameworks#3973
sentrivana merged 13 commits intomasterfrom
ivana/tox-script-4

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 20, 2025 •
edited
Loading

These mostly come from our existing tox.ini. They're used by the populate_tox.py script to filter out unsupported releases.

They are not actually checked in the integrations. Since they were more of a suggestion before than a hard requirement, we don't want an integration to suddenly stop working for someone who is on an older version. We can consider actually checking them in a new major.

@codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

❌ 52 Tests Failed:

Tests completed Failed Passed Skipped
22432 52 22380 5772
View the top 3 failed test(s) by shortest run time 
tests.integrations.strawberry.test_strawberry test_infer_execution_type_from_installed_packages_async
Stack Traces | 0.063s run time 
.../integrations/strawberry/test_strawberry.py:130: in test_infer_execution_type_from_installed_packages_async
    sentry_init(integrations=[StrawberryIntegration()])
tests/conftest.py:203: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:269: in __init__
    self._init_impl()
sentry_sdk/client.py:392: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:211: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/strawberry.py:81: in setup_once
    _patch_execute()
sentry_sdk/integrations/strawberry.py:293: in _patch_execute
    old_execute_sync = strawberry_schema.execute_sync
E   AttributeError: module 'strawberry.schema.schema' has no attribute 'execute_sync'
tests.integrations.strawberry.test_strawberry test_transaction_mutation[sync_app_client_factory-False-framework_integrations1]
Stack Traces | 0.063s run time 
.../integrations/strawberry/test_strawberry.py:554: in test_transaction_mutation
    sentry_init(
tests/conftest.py:203: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:269: in __init__
    self._init_impl()
sentry_sdk/client.py:392: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:211: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/strawberry.py:81: in setup_once
    _patch_execute()
sentry_sdk/integrations/strawberry.py:293: in _patch_execute
    old_execute_sync = strawberry_schema.execute_sync
E   AttributeError: module 'strawberry.schema.schema' has no attribute 'execute_sync'
tests.integrations.strawberry.test_strawberry test_transaction_no_operation_name[async_app_client_factory-True-framework_integrations0]
Stack Traces | 0.063s run time 
.../integrations/strawberry/test_strawberry.py:474: in test_transaction_no_operation_name
    sentry_init(
tests/conftest.py:203: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:269: in __init__
    self._init_impl()
sentry_sdk/client.py:392: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:211: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/strawberry.py:81: in setup_once
    _patch_execute()
sentry_sdk/integrations/strawberry.py:293: in _patch_execute
    old_execute_sync = strawberry_schema.execute_sync
E   AttributeError: module 'strawberry.schema.schema' has no attribute 'execute_sync'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana changed the title [3] Add more min versions of frameworks [2] Add more min versions of frameworks Jan 20, 2025
Base automatically changed from ivana/tox-script-1 to master February 11, 2025 10:13
@sentrivana sentrivana enabled auto-merge (squash) February 11, 2025 10:18
@sentrivana sentrivana disabled auto-merge February 11, 2025 10:18
@sentrivana sentrivana enabled auto-merge (squash) February 11, 2025 10:19
@sentrivana sentrivana merged commit 2ebaa7c into master Feb 11, 2025
147 of 149 checks passed
@sentrivana sentrivana deleted the ivana/tox-script-4 branch February 11, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @szokeasaurusrex