[1] Add tox generation script, but don't use it yet#3971
Merged
sentrivana merged 24 commits intomasterfrom Feb 11, 2025
Merged
Conversation
❌ 52 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Thanks for splitting up the PR, I think it is much easier to review now!
I added some questions and suggestions
scripts/populate_tox/populate_tox.py
Outdated
| return hasher.hexdigest() | ||
|
|
||
|
|
||
| def main(fail_on_changes: bool = False) -> None: |
Member
There was a problem hiding this comment.
This function seems a bit long – I think we should try to break it up into smaller functions. At a minimum, probably the code in the loop could be its own function
scripts/populate_tox/populate_tox.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
| fail_on_changes = len(sys.argv) == 2 and sys.argv[1] == "--fail-on-changes" | ||
| main(fail_on_changes) |
Member
There was a problem hiding this comment.
I think it might be a good idea to add some tests for this script. What do you think?
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentrivana
commented
Jan 28, 2025
sentrivana
commented
Jan 28, 2025
sentrivana
commented
Jan 28, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks better, but I am still struggling to understand some parts of the code. I think more comments and some small refactors would help.
Please see the individual comments; we could also discuss offline if you think that would help
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
approved these changes
Feb 10, 2025
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add:
In this PR, the script is set to ignore all integrations, so no tox configuration is actually added. However, it's still the script actually generating the real
tox.inifrom thetox.jinjatemplate.See follow-up PRs for more.
Supersedes #3920