fix(django): Fix errors when instrumenting Django cache#3855
Merged
Conversation
I was testing Spotlight with Sentry and realized things started to get slow and crashy. It looks like sometimes `args` is just an empty array on cache's `_instruments_call` causing lots of exceptions being thrown. This patch fixes that with explicit length checks and also adds a note for the missing instrumentation for `get_or_set` method. This might be related to #2122 and #3300.
sentrivana
approved these changes
Dec 5, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
===========================================
+ Coverage 66.07% 79.92% +13.84%
===========================================
Files 137 137
Lines 15403 15404 +1
Branches 2618 2620 +2
===========================================
+ Hits 10177 12311 +2134
+ Misses 4346 2221 -2125
+ Partials 880 872 -8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing Spotlight with Sentry and realized things started to get slow and crashy. It looks like sometimes
argsis just an empty array on cache's_instruments_callcausing lots of exceptions being thrown. This patch fixes that with explicit length checks and also adds a note for the missing instrumentation forget_or_setmethod. This might be related to #2122 and #3300.