fix(falcon): Don't exhaust request body stream#3768
Merged
antonpirker merged 2 commits intomasterfrom Nov 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3768 +/- ##
==========================================
- Coverage 79.90% 79.87% -0.04%
==========================================
Files 137 137
Lines 15373 15373
Branches 2608 2609 +1
==========================================
- Hits 12284 12279 -5
- Misses 2221 2223 +2
- Partials 868 871 +3
|
87cf66e to
da1b4fd
Compare
68e1839 to
80164b7
Compare
80164b7 to
29cff89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only read the cached
request._media, since readingrequest.mediawill exhaust therequest.bounded_streamif it has not been read before. Note that this means that we will now only send the JSON request body to Sentry if the Falcon request handler reads the JSON data.Fixes #3761