Make sentry-sdk[pure-eval] installable with pip==24.0#3757
Merged
sentrivana merged 1 commit intomasterfrom Nov 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3757 +/- ##
==========================================
+ Coverage 84.37% 84.38% +0.01%
==========================================
Files 136 136
Lines 14375 14375
Branches 2422 2422
==========================================
+ Hits 12129 12131 +2
Misses 1495 1495
+ Partials 751 749 -2 |
antonpirker
approved these changes
Nov 18, 2024
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
If this will keep on working if users have a "sentry-python[pure_eval]" in their requirements.txt file, that this is fine with me.
Contributor
Author
As far as I can tell from my tests and from reading up on it (the info is scarce) it should. In the worst case a revert is trivial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an issue with
pip==24.0where extras with an underscore in the name can't be installed, so e.g.pip install sentry-sdk[pure_eval]will claim there is nopure_evalextra.The issue is fixed in
pip>=24.1. Some folks are stuck using older versions though. We can fix it for them by renaming the extra topure-evalinstead, which makespip install sentry-sdk[pure-eval]work correctly in 24.0 too.(The underscore version
sentry-sdk[pure_eval]will continue to work after this change. Tested with pip and uv.)Closes #3754