[issue-2804] Handle the parameter stack_info for the LoggingIntegration#3745
Merged
antonpirker merged 1 commit intogetsentry:masterfrom Nov 7, 2024
Merged
[issue-2804] Handle the parameter stack_info for the LoggingIntegration#3745antonpirker merged 1 commit intogetsentry:masterfrom
stack_info for the LoggingIntegration#3745antonpirker merged 1 commit intogetsentry:masterfrom
Conversation
stack_info in the LoggingIntegrationstack_info in the LoggingIntegration
stack_info in the LoggingIntegrationstack_info for the LoggingIntegration
7c7ab83 to
39904d6
Compare
…k_info' (added in Python 3.2). When set to True the stack trace will be retrieved and properly handled
39904d6 to
8d62604
Compare
antonpirker
approved these changes
Nov 7, 2024
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
Looks good!
Thanks for adding this! Really cool! 💯
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
- Coverage 84.38% 84.37% -0.02%
==========================================
Files 136 136
Lines 14375 14375
Branches 2422 2422
==========================================
- Hits 12131 12129 -2
+ Misses 1495 1494 -1
- Partials 749 752 +3
|
Contributor
Author
Amazing ! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add capability for the logging integration to use the parameter 'stack_info' (added in Python 3.2). When set to True the stack trace will be retrieved and properly handled.
This feature is mapped in this issue.
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.