fix(httpx): Prevent Sentry baggage duplication#3728
Merged
antonpirker merged 5 commits intomasterfrom Nov 21, 2024
Merged
Conversation
Sentry baggage will get added to an HTTPX request multiple times if the same request is repeated. To prevent this from occurring, we can strip any existing Sentry baggage before adding Sentry baggage to the request. Fixes #3709
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3728 +/- ##
==========================================
- Coverage 79.89% 79.89% -0.01%
==========================================
Files 137 137
Lines 15373 15382 +9
Branches 2609 2610 +1
==========================================
+ Hits 12282 12289 +7
- Misses 2221 2222 +1
- Partials 870 871 +1
|
sentrivana
reviewed
Nov 12, 2024
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Found a typo. Overall looks good to me. Can we also add an httpx test specifically for the scenario where we were accumulating baggage?
sentrivana
approved these changes
Nov 12, 2024
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry baggage will get added to an HTTPX request multiple times if the same request is repeated. To prevent this from occurring, we can strip any existing Sentry baggage before adding Sentry baggage to the request.
Fixes #3709