fix(HTTP2Transport): Only enable HTTP2 when DSN is HTTPS#3678
Merged
Conversation
BYK
commented
Oct 21, 2024
Comment on lines
+773
to
+774
| "http2": self.parsed_dsn is not None | ||
| and self.parsed_dsn.scheme == "https", |
Member
Author
There was a problem hiding this comment.
This is the core change. All the rest is refactoring to make this easier to implement.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3678 +/- ##
==========================================
- Coverage 84.33% 84.31% -0.03%
==========================================
Files 133 133
Lines 14231 14241 +10
Branches 2398 2400 +2
==========================================
+ Hits 12002 12007 +5
- Misses 1485 1487 +2
- Partials 744 747 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.