Auto enable Litestar integration#3540
Merged
antonpirker merged 4 commits intogetsentry:masterfrom Nov 21, 2024
Merged
Conversation
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3540 +/- ##
==========================================
+ Coverage 79.89% 79.90% +0.01%
==========================================
Files 137 137
Lines 15373 15373
Branches 2609 2609
==========================================
+ Hits 12282 12284 +2
+ Misses 2221 2219 -2
Partials 870 870
|
Contributor
|
Hey @provinzkraut, thanks for the PR -- we can merge this once the Litestar integration has been available for some time. I'd wait for couple more releases. We also have a new major coming up soonish (probably still this year) so if we don't enable the integration until then, SDK 3.0 would be a good point to do it. |
antonpirker
approved these changes
Nov 21, 2024
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
Some time has passed and there were no bug reports about the Litestar integration, so we can auto enable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto enable the Litestar integration added in #3358.
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.