ref(metrics): Update type hints for tag values#3156
Merged
Conversation
d0a8ff9 to
b02d0a3
Compare
Remove None, Tuple, and List from the MetricTagValue type as these are not supported and might confuse the user
b02d0a3 to
3d22c5d
Compare
antonpirker
approved these changes
Jun 11, 2024
szokeasaurusrex
approved these changes
Jun 12, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good! Do we need to update any Python SDK docs in response to this change?
Member
Author
@szokeasaurusrex https://docs.sentry.io/platforms/python/metrics/ is already good |
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Remove Tuple and List from the MetricTagValue type as these are not supported and might confuse the user. See getsentry/relay#3691 for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
TupleandListfrom theMetricTagValuetype as these are not supported and might confuse the user. See getsentry/relay#3691 for more information.