Skip to content

fix(scope): Clear last_event_id on scope clear#3124

Merged
szokeasaurusrex merged 2 commits intomasterfrom
szokeasaurusrex/clear-last-event-id
Jun 6, 2024
Merged

fix(scope): Clear last_event_id on scope clear#3124
szokeasaurusrex merged 2 commits intomasterfrom
szokeasaurusrex/clear-last-event-id

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented Jun 3, 2024

This PR includes a change that was split off from #3114.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 2c9d73d to 3098df0 Compare June 3, 2024 14:05
@szokeasaurusrex szokeasaurusrex self-assigned this Jun 3, 2024
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 3098df0 to c08ff62 Compare June 5, 2024 14:12
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review June 5, 2024 14:15
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

szokeasaurusrex and others added 2 commits June 6, 2024 09:51
Co-authored-by: Adam Johnson <me@adamj.eu>
Add test to ensure that clearing the isolation scope clears the `last_event_id`.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 72ca529 to 7674bf2 Compare June 6, 2024 13:52
@szokeasaurusrex szokeasaurusrex merged commit 7674bf2 into master Jun 6, 2024
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/clear-last-event-id branch June 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants