fix(integrations): Do not use convenience decorator#3022
Merged
antonpirker merged 2 commits intomasterfrom Apr 26, 2024
Merged
Conversation
szokeasaurusrex
approved these changes
Apr 26, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Would be good to add a test for whatever behavior the user observed in the issue. Can wait to be done in a separate PR
Contributor
Author
This, or even better, figure out why our existing tests didn't discover this. As mentioned, the only thing it takes for it to error out is to have a super simple Starlette app and request any endpoint, which we already have tests for, but for some reason, they didn't fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for #3021. Removing the decorator gets rid of the issue.
We should follow up and fix the decorator later, e.g. here: #2892
Closes #3021
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.