Skip to content

feat(metrics): Make metrics work with gevent#2694

Merged
sentrivana merged 18 commits intomasterfrom
ivana/make-metrics-work-with-gevent
Feb 6, 2024
Merged

feat(metrics): Make metrics work with gevent#2694
sentrivana merged 18 commits intomasterfrom
ivana/make-metrics-work-with-gevent

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented Jan 31, 2024

Zylphrex
Zylphrex previously approved these changes Feb 1, 2024
@sentrivana sentrivana changed the title fix(metrics): Make metrics work with gevent feat(metrics): Make metrics work with gevent Feb 2, 2024
@sentrivana sentrivana marked this pull request as ready for review February 2, 2024 17:43
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sentrivana
Copy link
Copy Markdown
Contributor Author

@antonpirker Rewrote this to use ContextVar instead of threading.local if you want to take another look

Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sentrivana sentrivana merged commit e9d7b73 into master Feb 6, 2024
@sentrivana sentrivana deleted the ivana/make-metrics-work-with-gevent branch February 6, 2024 09:52
@sentrivana sentrivana linked an issue Feb 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make metrics work with gevent

3 participants