Capture multiple named groups again#2432
Merged
sentrivana merged 4 commits intomasterfrom Oct 11, 2023
Merged
Conversation
sl0thentr0py
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implemented support for more complex Django CMS URL patterns in #1773, however this led to a regression in how we capture multiple named groups in a URL pattern.
This PR reverts the Django CMS change and adds test cases that'll allow us to spot the regression should it happen again.
I'll include some rationale behind why I'm reverting the change vs. trying to make it work for both the Django CMS-style and multiple placeholder URL patterns in the issue where we track this regression.
Closes #2392