Skip to content

Prevent adding sentry-trace header multiple times#2235

Merged
antonpirker merged 10 commits intomasterfrom
antonpriker/1940-fix-trace-propagation-with-otel
Jul 11, 2023
Merged

Prevent adding sentry-trace header multiple times#2235
antonpirker merged 10 commits intomasterfrom
antonpriker/1940-fix-trace-propagation-with-otel

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Jul 7, 2023

If OpenTelementry is enabled, the sentry-trace headers should not be applied by Sentry intregration, but only by the OTel propagator.

Fixes #1940

@antonpirker antonpirker force-pushed the antonpriker/1940-fix-trace-propagation-with-otel branch from 8bb51ea to 456a352 Compare July 7, 2023 12:24
@antonpirker antonpirker changed the title Only propagate traces when Sentry instrumenter is used. Prevent adding sentry-trace header multiple times Jul 7, 2023
@antonpirker antonpirker marked this pull request as ready for review July 7, 2023 13:07
@antonpirker antonpirker requested a review from sl0thentr0py July 7, 2023 13:10
@antonpirker antonpirker enabled auto-merge (squash) July 11, 2023 08:30
@antonpirker antonpirker merged commit b89fa8d into master Jul 11, 2023
@antonpirker antonpirker deleted the antonpriker/1940-fix-trace-propagation-with-otel branch July 11, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry FastAPI and Requests

2 participants