Skip to content

feat(loguru): add message format configuration arguments#2208

Merged
sentrivana merged 9 commits intogetsentry:masterfrom
Gwill:master
Jun 30, 2023
Merged

feat(loguru): add message format configuration arguments#2208
sentrivana merged 9 commits intogetsentry:masterfrom
Gwill:master

Conversation

@Gwill
Copy link
Contributor

@Gwill Gwill commented Jun 28, 2023

More convenient setting message format.

@sentrivana
Copy link
Contributor

Hey @Gwill, thanks for this PR! Could you please run it through black to make this workflow green?

@sentrivana
Copy link
Contributor

Now mypy is complaining about this:

sentry_sdk/integrations/loguru.py:68: error: Argument "format" to "add" of "Logger" has incompatible type "str | None"; expected "str | Callable[[Record], str]"  [arg-type]
sentry_sdk/integrations/loguru.py:75: error: Argument "format" to "add" of "Logger" has incompatible type "str | None"; expected "str | Callable[[Record], str]"  [arg-type]

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gwill! Looks useful, will merge this now.

@sentrivana sentrivana enabled auto-merge (squash) June 30, 2023 12:46
@sentrivana sentrivana merged commit 0919a95 into getsentry:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants