Fix trace context in event payload#2205
Merged
antonpirker merged 13 commits intomasterfrom Jun 28, 2023
Merged
Conversation
sentrivana
approved these changes
Jun 28, 2023
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Looks good, please consider the small suggestion and comment
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Contributor
Author
|
We also have spans present if tracing is disabled, so the check needs to be there. |
Contributor
Author
|
Thanks for the better if, way nicer to read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that always a
tracecontext is added to the event payload. But also make sure that if there is already atracecontext in the event, do not overwrite it. (This used to be the behavior before tracing without performance. See: https://github.com/getsentry/sentry-python/blob/1.25.1/sentry_sdk/scope.py#L420)Fixes #2201