fix: fix propagation of OTEL NonRecordingSpan#2187
Merged
sentrivana merged 2 commits intogetsentry:masterfrom Jun 22, 2023
hartungstenio:non-recording-span
Merged
fix: fix propagation of OTEL NonRecordingSpan#2187sentrivana merged 2 commits intogetsentry:masterfrom hartungstenio:non-recording-span
sentrivana merged 2 commits intogetsentry:masterfrom
hartungstenio:non-recording-span
Conversation
Contributor
|
Hey @hartungstenio, thanks for fixing this! The changes look good to me. Happy to merge this as soon as the pipeline is green -- could you please take a look at what |
sentrivana
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #1995, while also applying the same fix to
SentrySpanProcessor.