Fix distribution name normalization (PEP-0503)#2144
Merged
sentrivana merged 1 commit intogetsentry:masterfrom May 25, 2023
Merged
Fix distribution name normalization (PEP-0503)#2144sentrivana merged 1 commit intogetsentry:masterfrom
sentrivana merged 1 commit intogetsentry:masterfrom
Conversation
Contributor
Author
|
I get the same error while building Fedora package on Fedora servers: https://kojipkgs.fedoraproject.org//work/tasks/659/101530659/build.log This prevents me from packaging newest version of |
bf039e9 to
a6fc449
Compare
Current logic in `test_installed_modules` does not properly handle
distributions with underscores. On my machine I get the following error
while running tests:
```
tests/integrations/modules/test_modules.py:60: in test_installed_modules
assert installed_modules == pkg_resources_modules
E AssertionError: assert {'aiven-clien...'22.2.0', ...} == {'aiven-clien...'22.2.0', ...}
E Omitting 93 identical items, use -vv to show
E Left contains 1 more item:
E {'tomli_w': '1.0.0'}
E Right contains 1 more item:
E {'tomli-w': '1.0.0'}
E Use -v to get more diff
```
This change fixes distribution name normalization by applying the code
from PEP-0503 (https://peps.python.org/pep-0503/#normalized-names).
a6fc449 to
3d6b8f6
Compare
Contributor
|
Hey @rominf, thanks a lot for fixing this! If the tests are green this LGTM. |
sentrivana
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current logic in
test_installed_modulesdoes not properly handledistributions with underscores. On my machine I get the following error
while running tests:
This change fixes distribution name normalization by applying the code
from PEP-0503 (https://peps.python.org/pep-0503/#normalized-names).