Conversation
074b739 to
85d7458
Compare
8293c19 to
2cba3d9
Compare
37128b8 to
7bbc515
Compare
7bbc515 to
8b19bf9
Compare
antonpirker
left a comment
There was a problem hiding this comment.
Why not just walk the whole event structure recursively and apply scrub_dict()?
As the implementation is now, when we (or somenone else) adds a top level key "super_secret_stuff" it will not be touched.
|
I get that having those seperate scrubbing functions makes it convenient for a user to derive a custom scrubber that works like the original one, but does not scrub for example the breadcrumbs. |
|
But maybe add a That does something like: (or something like |
Only python has the I think this is fine for a first version and we can see how and if users use this at all and wait for feedback. |
|
Ok. |
|
we can't ensure and that's fine |
Add a new
EventScrubberclass that scrubs certain potentially sensitive interfaces with aDEFAULT_DENYLIST. The default scrubber is automatically run ifsend_default_pii = False.Usage
As outlined in https://github.com/getsentry/rfcs/blob/main/text/0062-controlling-pii-and-credentials-in-sd-ks.md
closes #1897
docs: getsentry/sentry-docs#6489