Skip to content

Add support for Sentry Crons to Celery Beat#1935

Merged
antonpirker merged 14 commits intomasterfrom
antonpirker/1932-support-for-sentry-crons
Mar 16, 2023
Merged

Add support for Sentry Crons to Celery Beat#1935
antonpirker merged 14 commits intomasterfrom
antonpirker/1932-support-for-sentry-crons

Conversation

@antonpirker
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker commented Mar 1, 2023

This adds a decorator @sentry.monitor that can be attached to Celery tasks. When the celery tasks are run, a check-in for Sentry Crons is created and also the status of the check-in is set when the tasks fails for finishes.

Fixes #1932

@evanpurkhiser
Copy link
Copy Markdown
Member

Let's rename usages of monitor_id to monitor_slug

@antonpirker
Copy link
Copy Markdown
Contributor Author

@evanpurkhiser when will the monitor_slug updated be deployed to production?

@antonpirker antonpirker marked this pull request as ready for review March 13, 2023 13:40
reraise(*exc_info)

duration = nanosecond_time() - start_timestamp
capture_checkin(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably combine both in finally?

@antonpirker antonpirker merged commit f7b0684 into master Mar 16, 2023
@antonpirker antonpirker deleted the antonpirker/1932-support-for-sentry-crons branch March 16, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Sentry Crons to Celery Beat

3 participants