fix(django): Fix 404 Handler handler being labeled as "generic ASGI request"#1277
Merged
antonpirker merged 9 commits intogetsentry:masterfrom Jul 11, 2023
BeryJu:django-404-handler
Merged
fix(django): Fix 404 Handler handler being labeled as "generic ASGI request"#1277antonpirker merged 9 commits intogetsentry:masterfrom BeryJu:django-404-handler
antonpirker merged 9 commits intogetsentry:masterfrom
BeryJu:django-404-handler
Conversation
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
antonpirker
suggested changes
Jun 19, 2023
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
I have one consideration to make the change use less resources.
Contributor
|
It seems that we changed a lot since this PR was submitted originally. @BeryJu I know it is a lot to ask, but could you move your check for the 404 into the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.