Conversation
The find_cp_path helper used popen/pclose which are unavailable on consoles. Narrow the guard to match the platforms where the function is actually called: macOS and desktop Linux.
supervacuus
approved these changes
Feb 19, 2026
Collaborator
|
We don't have to fix this here, because it is apparent in multiple places, but we should likely formulate the compile-time exclusions for test negatively rather than positively (I.e., we vote a platform out of test rather than in). This is the better feedback mechanism, because new platforms are automatically covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_cp_pathhelper usedpopen/pclosewhich are unavailable on consoles. Narrow the guard to match the platforms where the function is actually called: macOS and desktop Linux.ps
nx
#skip-changelog