fix(cloudflare): Treat OAuth probe 4xx as expired#862
Merged
Conversation
Treat client-side failures from the upstream /auth/ probe as an expected signal that the stored Sentry token is no longer usable. Sentry can return 400 as well as 401 for invalid or expired bearer tokens, so limiting the fallback to ApiAuthenticationError created noisy issue reporting during refresh token exchange. Keep the regression coverage focused on probe behavior without asserting on telemetry internals. Fixes MCP-SERVER-F9Q Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat the refresh-token probe's client-side failures as an expected sign that the stored Sentry token is no longer usable.
While investigating MCP-SERVER-F9Q, the upstream /auth/ probe was returning 400 for invalid or expired bearer tokens. The refresh path only treated 401 authentication failures as expected, so these 400 responses were being logged as issues even though they should fall through to re-auth.
This broadens the probe guard to all ApiClientError responses and keeps the regression coverage focused on the 400 probe behavior without asserting on telemetry internals.
Fixes MCP-SERVER-F9Q