fix(utils): Fix XHR instrumentation early return#9770
Merged
Conversation
Closed
3 tasks
Contributor
size-limit report 📦
|
Lms24
approved these changes
Dec 7, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Checked and didn't find other similar early returns.
Yeah I guess we can't lint on returning void in a function that should return void 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #9542 😬
Ideally we could have a lint rule for this, but probably this is rather hard to do - so reminder to self to keep an eye out for this in the future!
Closes #9747
Note to reviewer(s): could you double check the file to make sure I didn't miss anything again? Just being cautious there...