feat(crons): Add interface for heartbeat checkin#9706
Merged
Conversation
AbhiPrasad
approved these changes
Nov 30, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Let's add a heartbeat checkin test?
anonrig
reviewed
Nov 30, 2023
| */ | ||
| public captureCheckIn(checkIn: CheckIn, monitorConfig?: MonitorConfig, scope?: Scope): string { | ||
| const id = checkIn.status !== 'in_progress' && checkIn.checkInId ? checkIn.checkInId : uuid4(); | ||
| const id = 'checkInId' in checkIn && checkIn.checkInId ? checkIn.checkInId : uuid4(); |
Contributor
There was a problem hiding this comment.
checkIn.hasOwnProperty('checkInId') might resolve into smaller footprint
Contributor
Author
There was a problem hiding this comment.
Bundle size wise in would be smaller. If you mean performance, I don't know if we should care. I'd assume the engines do their best in any case. This is not the hottest of hot paths and I don't have benchmarks or any documentation indicators what is faster so 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9703
I don't know if this is what we actually want.