feat(web-vitals): Vendor in INP from web-vitals library#9690
Merged
AbhiPrasad merged 1 commit intodevelopfrom Nov 28, 2023
Merged
feat(web-vitals): Vendor in INP from web-vitals library#9690AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
k-fish
approved these changes
Nov 28, 2023
Member
k-fish
left a comment
There was a problem hiding this comment.
Just vendored code, not used? 👍
Contributor
Author
Yup not used for now, but that can be added at any time once Relay is ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9660
vendored in from https://github.com/GoogleChrome/web-vitals/tree/7f0ed0bfb03c356e348a558a3eda111b498a2a11
Note that this is on web vitals
v3.0.4. We need to update to latest web vitals version - will do this in a follow up PR.