Conversation
…rom core (#9432) Remove the use of our temporary ingest endpoint, and use our normal ingestion instead.
[Gitflow] Merge master into develop
We talked about this a few times, maybe increasing the timeout here helps!
Exported a type to be used like:
```typescript
export const meta = ({ data }: SentryMetaArgs<MetaFunction<typeof loader>>) => {
return [
{
env: data.ENV,
},
{
name: 'sentry-trace',
content: data.sentryTrace,
},
{
name: 'baggage',
content: data.sentryBaggage,
},
];
};
```
So the types from `loader` function and our injections are both
available in type checking.
Also, updated e2e tests to include `meta` injection checks for root and
sub-routes.
Astro's Vite plugin tries to detect if a package is an "astro component package" (i.e. contains `.astro`) files by checking for a bunch of heuristics in the project's `package.json`. These packages will be run through the Astro compiler. https://github.com/withastro/astro/blob/7c458514c06c95158245bba4fa3c254abd333f5a/packages/astro/src/core/create-vite.ts#L74-L89 Because our SDK package matches multiple of the used heuristics, it is added to the compiler build which causes errors because some of our packages make the build fail (not sure why/how). Apparently, this is only problematic when the project is managed by `pnpm` which results in a build error. Other package managers don't seem to have a problem.
Add `<meta>` tag injection in our new `handleRequest` Astro middleware to enable distributed traces between BE and FE transactions. This is also the first step towards exporting a `<meta>` tag helper function (tracked in #8438). In a future PR I'll extract the function to the core or utils package and export it in our server-side SDKs.
lforst
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.100.0 next week lol