fix(integrations): Fix transaction integration#9334
Merged
Conversation
3 tasks
lforst
approved these changes
Oct 23, 2023
Contributor
lforst
left a comment
There was a problem hiding this comment.
I assume we need this out quickly but we should add tests that catch this.
Member
Author
|
Well I changed the tests to catch this, just the way the test was written was not suited to catch this 😬 |
Contributor
|
I should learn to read |
HoukmellahMehdi
pushed a commit
to HoukmellahMehdi/sentry-javascript
that referenced
this pull request
Oct 23, 2023
This was not covered well by our tests 😬 oops... Fixes getsentry#9332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not covered well by our tests 😬 oops...
Fixes #9332