fix(core): Narrow filters for health check transactions#9257
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Oct 16, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
we can always broaden certain ones again if needed 👍
lforst
approved these changes
Oct 16, 2023
| expect(eventProcessor(TRANSACTION_EVENT_HEALTH_3, {})).toBe(TRANSACTION_EVENT_HEALTH_3); | ||
| }); | ||
|
|
||
| it.each(['/delivery', '/already', '/healthysnacks'])( |
Contributor
There was a problem hiding this comment.
I find this funny for some reason
Member
Author
There was a problem hiding this comment.
fwiw before thinking of "already" my example for ready was bready 👀 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported internally via Slack, our filters for health check transactions (which we unfortunately added to the SDK a while ago) were partially far too broad, filtering out transactions like
/deliverybecause they matched the/^.*live.*$/regex. This PR narrows down the regexes so that they no longer only require a partial but a full match.I'd still rather nuke the entire filters array, given that we filter on the backend anyway, but there's a point to be made that the filters in the SDK avoid unnecessary traffic to Relay.
ref getsentry/team-webplatform-meta#70