feat(tracing): allow direct pg module to enable esbuild support#9227
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Oct 12, 2023
Merged
feat(tracing): allow direct pg module to enable esbuild support#9227AbhiPrasad merged 2 commits intogetsentry:developfrom
AbhiPrasad merged 2 commits intogetsentry:developfrom
Conversation
caecb78 to
5b58bcc
Compare
5b58bcc to
260a232
Compare
9 tasks
aldenquimby
commented
Oct 11, 2023
| return; | ||
| } | ||
|
|
||
| const { Client } = this._usePgNative ? pkg.native : pkg; |
Contributor
Author
There was a problem hiding this comment.
pkg.native?.Client is now nullable to align with @types/pg. Unfortunately TS is not great with multiple boolean conditions. The changes here were the least disruptive I could come up with
AbhiPrasad
approved these changes
Oct 12, 2023
Contributor
Contributor
Author
|
@AbhiPrasad thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Background
Proposal
Alternatives
commonjsMagicComments, that should do the trick