Conversation
lforst
approved these changes
Jun 19, 2024
AbhiPrasad
reviewed
Jun 19, 2024
|
|
||
| ## 3. Meta SDKs | ||
|
|
||
| Meta SDKs should contain both the things pointed out in 1. and 2, _PLUS_: |
Contributor
There was a problem hiding this comment.
We should include a note about source maps uploading and multiple JS runtimes.
s1gr1d
approved these changes
Jun 20, 2024
Member
Author
|
I included PR feedback, please give it another read! |
andreiborza
reviewed
Jun 25, 2024
andreiborza
reviewed
Jun 25, 2024
andreiborza
approved these changes
Jun 25, 2024
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a doc page with infos about creating a new SDK.
See: https://github.com/getsentry/sentry-javascript/blob/fn/new-sdk-docs/docs/creating-a-new-sdk.md