fix(profiling): continuous profile chunks should be in seconds#12532
Merged
fix(profiling): continuous profile chunks should be in seconds#12532
Conversation
AbhiPrasad
approved these changes
Jun 18, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
We can get this release tomorrow.
c4a350c to
1e71d15
Compare
Member
Author
That would be great ❤️ I'm trying to get some profiles from chartcuterie so we can validate the SDKs are good and can focus on the UI. The next part after that is to port this to the browsers SDK as well so we can finally move away from mostly profiling pageloads |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timestamps reported in the chunk format need to be in seconds