fix(replay): Ignore old events when manually starting replay#12349
Merged
fix(replay): Ignore old events when manually starting replay#12349
Conversation
Contributor
size-limit report 📦
|
c298lee
reviewed
Jun 4, 2024
Contributor
|
What happens if there is a sample rate and the user calls |
billyvg
approved these changes
Jun 4, 2024
Member
billyvg
left a comment
There was a problem hiding this comment.
A lot simpler fix than I figured, amaze!
Co-authored-by: Catherine Lee <55311782+c298lee@users.noreply.github.com>
Member
Author
If you call |
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
This PR ensures that if a replay is manually started (=no sample rates are defined at all, and a user later calls `start()` or `startBuffering()`, we do not back-port the `initialTimestamp` of the replay based on the event buffer. By default (for the first segment) we'll backport the `initialTimestamp` to the time of the first event in the event buffer, to ensure that e.g. the pageload browser metrics that may be emitted with an earlier timestamp all show up correctly. However, this may be unexpected if manually calling `startBuffering()` and seeing things for stuff that happened before. Now, we keep track of this and adjust the behavior accordingly. Fixes #11984 --------- Co-authored-by: Catherine Lee <55311782+c298lee@users.noreply.github.com>
This was referenced Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that if a replay is manually started (=no sample rates are defined at all, and a user later calls
start()orstartBuffering(), we do not back-port theinitialTimestampof the replay based on the event buffer.By default (for the first segment) we'll backport the
initialTimestampto the time of the first event in the event buffer, to ensure that e.g. the pageload browser metrics that may be emitted with an earlier timestamp all show up correctly.However, this may be unexpected if manually calling
startBuffering()and seeing things for stuff that happened before.Now, we keep track of this and adjust the behavior accordingly.
Fixes #11984