feat(redis-cache): Create cache-span with prefixed keys (get/set commands)#12070
Merged
feat(redis-cache): Create cache-span with prefixed keys (get/set commands)#12070
Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
May 16, 2024
Comment on lines
+22
to
+24
| name: 'Test Transaction', | ||
| op: 'transaction', | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| name: 'Test Transaction', | |
| op: 'transaction', | |
| }, | |
| name: 'Test Span', | |
| op: 'test-span', | |
| }, |
let's avoid transaction wording in new code :D
mydea
approved these changes
May 16, 2024
mydea
reviewed
May 16, 2024
| else if (response === null || response === undefined) return 0; | ||
| return JSON.stringify(response).length; | ||
| } catch (e) { | ||
| return 0; |
Member
There was a problem hiding this comment.
m: Should we return undefined here? Maybe it is more confusing to set this to 0 if something fails, than to not set it at all?
mydea
reviewed
May 16, 2024
| return; | ||
| } | ||
|
|
||
| const networkPeerAddress = spanToJSON(span).data?.['net.peer.name']; |
Member
There was a problem hiding this comment.
out of interest, are we using something non-standard here or is redis emitting something non-standard?
Member
Author
There was a problem hiding this comment.
redis seems to be using the old standard as there was a change to those params: open-telemetry/opentelemetry-specification#3199
We are using those: https://opentelemetry.io/docs/specs/semconv/attributes-registry/network/
Member
There was a problem hiding this comment.
ok, got it, makes sense - maybe we can leave a comment like this in the code so we can potentially revisit this when we update the redis instrumentation at some point :)
mydea
approved these changes
May 16, 2024
This was referenced Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populates the OTel span with cache attributes. Currently,
getandsetcommands are considered.