fix(core): Avoid looking up client for hasTracingEnabled() if possible#12066
Merged
fix(core): Avoid looking up client for hasTracingEnabled() if possible#12066
hasTracingEnabled() if possible#12066Conversation
This is a bit weird in that we access the current scope & client etc., even if options are passed. Since we also use this method in `init()` before we have setup stuff, it seems safer to avoid calling this at all if possible.
andreiborza
approved these changes
May 16, 2024
Contributor
size-limit report 📦
|
This was referenced Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit weird in that we access the current scope & client etc., even if options are passed. Since we also use this method in
init()before we have setup stuff, it seems safer to avoid calling this at all if possible.This is related to #12054, but not really the cause of it.