Skip to content

Fork isolation scope for root spans in OtelSentrySpanProcessor instead of OtelSentryPropagator#4434

Merged
adinauer merged 6 commits intomainfrom
feat/otel-fork-isolation-scope-in-span-processor
May 23, 2025
Merged

Fork isolation scope for root spans in OtelSentrySpanProcessor instead of OtelSentryPropagator#4434
adinauer merged 6 commits intomainfrom
feat/otel-fork-isolation-scope-in-span-processor

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented May 22, 2025 •
edited
Loading

📜 Description

Fork isolation scope for root spans in OtelSentrySpanProcessor instead of OtelSentryPropagator.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 758fd84

@lcian
Copy link
Copy Markdown
Member

lcian commented May 22, 2025 •
edited
Loading

Tested this with a library that doesn't have OTEL instrumentation (Pekko GRPC), using the OTEL API (OtelSentryPropagator) and things work as expected.
Will test Spring Boot and some more server library next, to confirm there are no unwanted side-effects.
And also with the Sentry API as opposed to the OTEL one.

@adinauer
Copy link
Copy Markdown
Member Author

adinauer commented May 23, 2025

Tested using our console OTel sample as well as Spring Boot 3 with Agent and Agentless. All of them work as expected.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 23, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 492.22 ms 583.85 ms 91.62 ms
Size 1.58 MiB 2.08 MiB 510.85 KiB

Previous results on branch: feat/otel-fork-isolation-scope-in-span-processor

Startup times

Revision Plain With Sentry Diff
fb0d103 449.29 ms 474.78 ms 25.49 ms
f498992 396.34 ms 416.38 ms 20.04 ms

App size

Revision Plain With Sentry Diff
fb0d103 1.58 MiB 2.08 MiB 510.85 KiB
f498992 1.58 MiB 2.08 MiB 510.85 KiB

@adinauer adinauer merged commit 2fbb2e3 into main May 23, 2025
34 checks passed
@adinauer adinauer deleted the feat/otel-fork-isolation-scope-in-span-processor branch May 23, 2025 11:21
rbro112 pushed a commit that referenced this pull request May 23, 2025
@adinauer @rbro112
Fork isolation scope for root spans in OtelSentrySpanProcessor inst…
b623b2a 
…ead of `OtelSentryPropagator` (#4434)

* Fork isolation scope in SpanProcessor

* improve creator strings

* changelog

* remove irrelevant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Isolation scope is never forked for root spans if propagator is not invoked

2 participants

@adinauer @lcian