POTEL 67 - Add openTelemetryMode option#3994
Merged
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 25b4e26 | 375.50 ms | 426.00 ms | 50.50 ms |
| 75859e1 | 405.08 ms | 466.24 ms | 61.16 ms |
| a58d1ae | 404.23 ms | 424.78 ms | 20.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 25b4e26 | 1.65 MiB | 2.31 MiB | 676.61 KiB |
| 75859e1 | 1.65 MiB | 2.31 MiB | 676.61 KiB |
| a58d1ae | 1.65 MiB | 2.31 MiB | 676.57 KiB |
lbloder
reviewed
Dec 20, 2024
| options.setEnableExternalConfiguration(true); | ||
| options.setInitPriority(InitPriority.HIGH); | ||
| OpenTelemetryUtil.applyOpenTelemetryOptions(options, SentryOpenTelemetryMode.AGENT); | ||
| options.setOpenTelemetryMode(SentryOpenTelemetryMode.AGENT); |
Collaborator
There was a problem hiding this comment.
Shouldn't we leave that on AUTO here and let the OpenTelemetryUtils decide?
The SentryAutoConfigurationCustomizerProvider is also present in the sentry-opentelemetry-agentless case and if a SENTRY_PROPERTIES_FILE or SENTRY_DSN environment variable is present, it would auto-init unless skipInit is specifically set like in SentryOpenTelemetryNoAgentConfiguration for Spring integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
openTelemetryModeoption💡 Motivation and Context
So customers don't have to add
OpenTelemetryUtil.apply...to their applications and instead have the SDK figure out automatically in what way to use OpenTelemetry.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
OFFenum option but that would require us to initializeScopesStoragelater to first read the option and only then initialize it. It would have to be NOOP before.